Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ranges>: Consistently check preconditions for iota_view and _Counted_fn #4616

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4586.

Also completes precondition checking for [range.iota.view]/10, and adds some previous missed comments // _CONTAINER_DEBUG_LEVEL > 0.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner April 21, 2024 23:56
@StephanTLavavej StephanTLavavej added enhancement Something can be improved ranges C++20/23 ranges labels Apr 22, 2024
@StephanTLavavej StephanTLavavej self-assigned this Apr 22, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit bf1e9bd into microsoft:main Apr 26, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

✅ ✅ ✅

@frederick-vs-ja frederick-vs-ja deleted the stl-verify-ranges branch April 27, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved ranges C++20/23 ranges
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<ranges>: iota_view and _Counted_fn inconsistently use _STL_ASSERT for precondition checking
2 participants