Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python backslashreplace to avoid UNRESOLVED tests #4366

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Use Python backslashreplace to avoid UNRESOLVED tests #4366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/utils/stl/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ def decodeOutput(bytes):
try:
return bytes.decode()
except UnicodeError:
# Use 'backslashreplace' to avoid throwing another exception for unrecognized characters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fond of "unrecognized characters" which suggests that the transcoder doesn't understand the source character set; the issue here is that tests sometimes emit byte sequences that aren't valid encoded characters. I'd prefer something like "when tests emit garbage bytes."

This is absolutely not worth resetting testing.

import locale
return bytes.decode(locale.getpreferredencoding(do_setlocale=False))
return bytes.decode(locale.getpreferredencoding(do_setlocale=False), 'backslashreplace')


def executeCommand(command, cwd=None, env=None, input=None, timeout=0):
Expand Down