<xlocnum>: Drop ios_base::showpoint flag when printing non-finite values
#4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Nov 28, 2023
|
Thanks! I pushed changes to fix the test and some minor nitpicks. I think this needs only one maintainer approval. This affects separately compiled code but we don't need to wait for a redist update because it's not making coordinated changes between the headers and DLL. (Also 17.10 will be unlocked at some point.) Thanks for thinking about that, it's easy to forget. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Infinite thanks for this fix! 🐞 🛠️ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4210.
This PR is a workaround for DevCom-10519861 and may be
affects redistbecause it modifies dll-exported functions.