-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.8 Preview 3 #4083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the internal toolset has been updated. Validated internally, we can resolve this bug when merging.
…action with other std containers with only non-member begin() functions". This wasn't a compiler or STL bug; it was a reminder to maybe file an LWG issue someday, which never happened and isn't worth pursuing now.
…lly resolved as By Design. Permanently avoid it by separately asserting each expression, which is our preferred style anyways.
…tion may not be standard conformant". It was fixed on 2023-06-02 by MSVC-PR-468038 in prod/be and is present in both rel/17.7 and rel/17.8. It was marked as fixed in 17.8 Preview 1.
…ision" (a User Story that's been Proposed since 2019-11-22) with fine-grained workarounds for VSO-1899423 "C1XX mishandles C++17 deferred temporary materialization in is_invocable_r_v and is_nothrow_invocable_r_v" (newly reported with this exact code).
CaseyCarter
reviewed
Oct 11, 2023
tests/std/tests/VSO_0000000_instantiate_containers/test.compile.pass.cpp
Show resolved
Hide resolved
CaseyCarter
approved these changes
Oct 11, 2023
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cbegin
interaction with other std containers with only non-memberbegin()
functions". This wasn't a compiler or STL bug; it was a reminder to maybe file an LWG issue someday, which never happened and isn't worth pursuing now.tr1
, this is worth it.memchr
implementation may not be standard conformant". It was fixed on 2023-06-02 by MSVC-PR-468038 inprod/be
and is present in bothrel/17.7
andrel/17.8
. It was marked as fixed in 17.8 Preview 1.is_invocable_r_v
andis_nothrow_invocable_r_v
" (newly reported with this exact code).