Follow-up enhancements for <filesystem>
#3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r 14 pushes in current impl
achabense
commented
Jul 17, 2023
StephanTLavavej
added
bug
strega-nil-ms
approved these changes
Jul 18, 2023
StephanTLavavej
approved these changes
Jul 18, 2023
| @@ -3230,8 +3220,7 @@ namespace filesystem { | |||
| return _Err; | |||
| } | |||
|
|
|||
| _Result._Text.resize(_Length); | |||
| _CSTD memcpy(_Result._Text.data(), _Offset, _Length * sizeof(wchar_t)); | |||
| _Result._Text.assign(_Offset, _Length); | |||
There was a problem hiding this comment.
No change requested: This is great, thank you for noticing it!
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks again for noticing and fixing another one of these bugs! 🦅 👁️ 🐞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noexceptsignature for_Read_symlinkSTL/stl/inc/filesystem
Line 3233 in f51733c
_Absoluteintoabsolute, as it's simple enough// for exception safetycomment; make benchmark cases look better; make the vector reserve slightly more space inlexically_normal