Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Final cleanups #3852

Merged
merged 21 commits into from
Jul 8, 2023
Merged

<mdspan>: Final cleanups #3852

merged 21 commits into from
Jul 8, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

  • Privatize implementation-defined constructors,
  • Strengthen various functions,
  • Address comments from previous PRs:
  • Add extra _STL_INTERNAL_STATIC_ASSERT in various places,
  • Simplify _Make_dynamic_indices_inv and fix size of _Dynamic_indices_inv array,
  • Make check_members_with_various_extents test less heavy.

After this PR <mdspan> will be ready for final review 😸

@JMazurkiewicz
extents: Make special constructors private
f58adf8
@JMazurkiewicz
Use _STL_INTERNAL_STATIC_ASSERT in _*_prod_of_extents instead of …
a0272c1 
…`requires` clause
@JMazurkiewicz
Strengthen layout_left(layout_stride) constructor
46b7a2b
@JMazurkiewicz
Strengthen mdspan() constructor
42e6f21
@JMazurkiewicz
Strengthen mdspan(data_handle, extents...) constructor
a2154e5
@JMazurkiewicz
Strengthen mdspan(data_handle, array/span) constructor
18e1fad
@JMazurkiewicz
Strengthen mdspan(data_handle, const extents_type&) constructor
6535652
@JMazurkiewicz
Strengthen mdspan(data_handle, const mapping_type&) constructor
f789947
@JMazurkiewicz
Strengthen `mdspan(data_handle, const mapping_type&, const accessor_t…
bd8c60a 
…ype&)` constructor
@JMazurkiewicz
Strengthen mdspan(const other-mdspan&) constructor
a6991f4
@JMazurkiewicz
Strengthen mdspan::operator[indices...]
ce4d983
@JMazurkiewicz
Grammar: as value -> as a value
d3c4e46 
Addresses microsoft#3821 (comment)
@JMazurkiewicz
Use "This test assumes that it isn't being compiled with /J"
27e8937 
Addresses microsoft#3821 (comment)
@JMazurkiewicz
layout_right -> layout_stride
82116f9 
Addresses microsoft#3821 (comment)
@JMazurkiewicz
auto -> mdspan
7fcd00a 
Addresses microsoft#3821 (comment)
@JMazurkiewicz
Simplify extents::_Make_dynamic_indices_inv
c1d6b4d
@JMazurkiewicz
Fix noexcept specifier of mdspan::_Access_impl
4475d23
@JMazurkiewicz
Make check_members_with_various_extents less heavy
162e73b
@JMazurkiewicz
Copy-paste: noop_dtor -> empty_bases
16c8c74 
Addresses microsoft#3847 (comment)
@JMazurkiewicz
Typo: default_accesor -> default_accessor + grammar fix
ccf0413 
Addresses microsoft#3847 (comment)
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner July 7, 2023 18:12
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label Jul 7, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 7, 2023
StephanTLavavej
StephanTLavavej reviewed Jul 7, 2023
View reviewed changes
stl/inc/mdspan Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Jul 7, 2023
@StephanTLavavej StephanTLavavej merged commit 2c495f5 into microsoft:feature/mdspan2 Jul 8, 2023
35 checks passed
@JMazurkiewicz JMazurkiewicz deleted the mdspan/final branch July 8, 2023 06:33
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
mdspan C++23 mdspan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMazurkiewicz @StephanTLavavej