Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Improve accessor testing #3616

Merged
merged 1 commit into from
Apr 4, 2023
Merged

<mdspan>: Improve accessor testing #3616

merged 1 commit into from
Apr 4, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

default_accessor:

Testing:

  • Hide internal functions and concepts from test_mdspan_support.hpp header in detail namespace,
  • Implement checking for accessor policy requirements ([mdspan.accessor.reqmts]),
  • Check those requirements for default_accessor.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner April 3, 2023 12:08
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label Apr 3, 2023
@StephanTLavavej StephanTLavavej merged commit 32853a6 into microsoft:feature/mdspan2 Apr 4, 2023
@StephanTLavavej
Copy link
Member

Access granted! ✅ 🔓 😹

@JMazurkiewicz JMazurkiewicz deleted the mdspan/default_accessor_tests branch April 4, 2023 00:24
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
mdspan C++23 mdspan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMazurkiewicz @StephanTLavavej