Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1206R7 Conversions From Ranges To Containers #2806

Merged
merged 38 commits into from
Aug 9, 2022
Merged

P1206R7 Conversions From Ranges To Containers #2806

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
a47b6d0
P1206R7 Conversions From Ranges To Containers
CaseyCarter Dec 19, 2021
a62fe8b
WIP
CaseyCarter Jun 20, 2022
4e59216
Fixes
CaseyCarter Jun 21, 2022
2cb4fe9
fix feature-test macro test
CaseyCarter Jun 21, 2022
b5d02f4
frederick-vs-ja's deque comments
CaseyCarter Jun 22, 2022
5fae89b
factor commonality from forward_list::insert_range_after and ::insert…
CaseyCarter Jun 22, 2022
593e9a1
Fix inadvertent comment damage
CaseyCarter Jun 22, 2022
3b687e8
miscco's review comments
CaseyCarter Jun 24, 2022
ccf85f4
STL's review comments
CaseyCarter Jun 24, 2022
b2a0262
Consistently use `_Iter, _Sent` in container code
CaseyCarter Jun 24, 2022
e75816a
Revert accidental change to libcxx/usual_matrix.lst
CaseyCarter Jun 24, 2022
3e6b68f
enum_class{underlying_value} is C++17
CaseyCarter Jun 24, 2022
29feac1
cpplearner's comment; Update LWG issue number
CaseyCarter Jun 27, 2022
073cc1a
Review comments
CaseyCarter Jul 23, 2022
06614a3
Revert clang-format noise
CaseyCarter Jul 25, 2022
56eadd0
clang-format
CaseyCarter Jul 25, 2022
1612f7b
Nicole's review comments
CaseyCarter Jul 28, 2022
412e87d
Rename adaptor_adaptor to accessible_adaptor
CaseyCarter Jul 28, 2022
baa2afa
Surely I don't need to run _all_ the tests before pushing??!?
CaseyCarter Jul 28, 2022
e213a64
Merge branch 'main' into p1206
StephanTLavavej Aug 8, 2022
148de4b
Fix comment typo.
StephanTLavavej Aug 8, 2022
748e8fd
Fix merge: apply `_Is_meow_iter_v` => `_Is_cpp17_meow_iter_v` renaming.
StephanTLavavej Aug 8, 2022
6eafabd
Rename to P1206R7_forward_list_insert_range_after.
StephanTLavavej Aug 8, 2022
cb3b81d
Add `// Validate non-views` comments.
StephanTLavavej Aug 8, 2022
d05cbd8
Reorder definitions: _UFirst then _ULast.
StephanTLavavej Aug 8, 2022
8ffc780
Reduce scope of clang-format suppression.
StephanTLavavej Aug 8, 2022
bb956af
Change `std::` to `_STD`.
StephanTLavavej Aug 8, 2022
7641514
Qualify `_RANGES to`.
StephanTLavavej Aug 8, 2022
d424e80
Simplify how access control interacts with ifdefs.
StephanTLavavej Aug 8, 2022
7883bd4
Fix comments.
StephanTLavavej Aug 8, 2022
371deba
Avoid redundant namespace alias.
StephanTLavavej Aug 8, 2022
b983211
constexpr string/vector are always available, reported VSO-1588614.
StephanTLavavej Aug 8, 2022
e9c4a4e
Avoid redundant `constexpr const`.
StephanTLavavej Aug 8, 2022
b9d8186
Drop unnecessary `std::` in tests.
StephanTLavavej Aug 8, 2022
a4932c5
Use `bool` for expected arrays.
StephanTLavavej Aug 8, 2022
5582f29
Apply `defined(__cpp_lib_concepts)` cleanup.
StephanTLavavej Aug 8, 2022
4c9dc79
Chack construction from `const from_range_t&` instead of `from_range_t`
CaseyCarter Aug 8, 2022
d2cc9ed
`_Copy_n_unchecked` is a zombie
CaseyCarter Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stl/inc/ranges
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6725,8 +6725,9 @@ namespace ranges {
&& constructible_from<_Container, _Rng, _Types...>;

template <class _Rng, class _Container, class... _Types>
concept _Converts_tag_constructible = _Ref_converts<_Rng, _Container> //
&& constructible_from<_Container, from_range_t, _Rng, _Types...>;
concept _Converts_tag_constructible = _Ref_converts<_Rng, _Container>
// per LWG issue unnumbered as of 2022-08-08
&& constructible_from<_Container, const from_range_t&, _Rng, _Types...>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this issue recently too.
And when I used MSVC-STL for resolution validation I found that you already dealt with it. Are you planning to file this LWG and stride_view::iterator::operator+= recently?


template <class _Rng, class _Container, class... _Types>
concept _Converts_and_common_constructible = _Ref_converts<_Rng, _Container> && common_range<_Rng> //
Expand Down