-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.1 Preview 4, ARM64EC #2496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Jan 21, 2022
This was "EDG rejects `hash<optional<const B>>` called with `optional<B>`".
This was "Standard Library Header Units: Adding `template <int = 0>` to `vformat()` emits warnings C4265 and C4365".
This is "Standard Library Header Units: #pragma warning doesn't always suppress warnings in templates".
StephanTLavavej
force-pushed
the
vs-17.1-p3
branch
3 times, most recently
from
January 22, 2022 06:28
6d033fb
to
061da5c
Compare
StephanTLavavej
force-pushed
the
vs-17.1-p3
branch
3 times, most recently
from
January 25, 2022 03:48
c19b306
to
a65f230
Compare
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
force-pushed
the
vs-17.1-p3
branch
2 times, most recently
from
January 25, 2022 12:07
6f56111
to
2fc770b
Compare
StephanTLavavej
force-pushed
the
vs-17.1-p3
branch
from
January 25, 2022 21:53
2fc770b
to
bdb6c2b
Compare
StephanTLavavej
changed the title
Toolset update: VS 2022 17.1 Preview 3, ARM64EC
Toolset update: VS 2022 17.1 Preview 4, ARM64EC
Jan 25, 2022
barcharcraz
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format stuff looks good (as do other changes, however I spent more attention on format stuff)
CaseyCarter
approved these changes
Jan 26, 2022
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools/move_only_function_specializations
totools/scripts
.move_only_function_specializations.py
.<functional>
accordingly.move_only_function_specializations.py
explaining what it does - even though the filename and code are fairly self-explanatory, as we accumulate scripts, it will be helpful for each of them to briefly mention what they do, so we don't need to deduce their intent from their code.tools/scripts/print_failures.py
.FAIL
andXPASS
tests, then decoding their JSON with search-and-replace (replacing CRLFs and LFs with newlines, unescaping double quotes and backslashes).P0220R1_optional/test.cpp
.hash<optional<const B>>
called withoptional<B>
".subrange
.<format>
.template <int = 0>
tovformat()
emits warnings C4265 and C4365".<format>
's use offill_n
.'0'
can convertchar
towchar_t
._CharT{'0'}
forms the same type, avoiding the warning.<format>
.#pragma warning
doesn't always suppress warnings in templates", which @cdacamar has fixed in VS 2022 17.2 Preview 2.char
tochar/wchar_t
and silencing the warnings, we can use a function object totransform()
with astatic_cast
. This is more elegant than silencing warnings, and should result in identical release codegen. (Debug mode has more function calls, but avoiding them isn't all-important.)ranges::transform()
can directly takestring_view
.create-vmss.ps1
: Allow QUIC, renumber priorities.'Microsoft.VisualStudio.Component.VC.Tools.ARM64EC'
for Add arm64EC pipeline. Disable all SSE usage for ARM64EC #2491.create-vmss.ps1
: Also set the Azure CLI subscription.create-vmss.ps1
: Use member enumeration and the-in
containment operator, makingFind-ResourceGroupNameCollision
unnecessary.'THHmm'
to VMSS names.-1
,-2
, etc. suffix logic as it's theoretically needed, although in practice it should never appear. (Note that I tested the suffix logic changes before adding these timestamp changes.)vmss-config.json
andvmss-protected.json
anymore!--https-only
, exactly following the documentation. (I think--https-only
might have been the actual fix, but I didn't confirm that.)'__DIAGNOSTIC_STORAGE_ACCOUNT__'
and'__VM_OR_VMSS_RESOURCE_ID__'
invmss-config.json
, following the documentation. (I wasn't previously instructed that this was necessary, but in retrospect these strings are obviously placeholders.)--protected-settings
, avoiding saving the SAS token to disk. I'm leaving/azure-devops/vmss-protected.json
mentioned in.gitignore
.vmss-config.json
is too big to pass on the command line, so it must be saved to a file.create-vmss.ps1
: UseOut-Null
instead of ignored variables.README.md
.