Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strike "with concepts support" from the GH-1814 messages #2382

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Dec 8, 2021

Our supported C++latest frontends (clang-cl and msvc) both have concepts support, so this appears redundant.

Fixes DevCom-1603100
Closes VSO-1445646 / AB#1445646

Our supported C++latest frontends (clang-cl and msvc) both have concepts support, so this appears redundant.

Fixes DevCom-1603100
@CaseyCarter CaseyCarter added the documentation Related to documentation or comments label Dec 8, 2021
@CaseyCarter CaseyCarter requested a review from a team as a code owner December 8, 2021 01:02
@StephanTLavavej
Copy link
Member

I don't understand - we support EDG in c++latest mode, but it lacks full support for concepts, so we exclude format/ranges/etc.

Is the theory here that because we treat EDG-for-STL-testing and EDG-for-IntelliSense differently (where we activate concepts anyways, by special request), that users are confused by the "with concepts support" part? If so, this change would make sense to me, but I think the PR description should mention this.

@CaseyCarter
Copy link
Member Author

I don't understand - we support EDG in c++latest mode, but it lacks full support for concepts, so we exclude format/ranges/etc.

Is the theory here that because we treat EDG-for-STL-testing and EDG-for-IntelliSense differently (where we activate concepts anyways, by special request), that users are confused by the "with concepts support" part? If so, this change would make sense to me, but I think the PR description should mention this.

The issue is that C++20 has been published, so today "C++latest" means "support for C++ beyond C++20." The set of compilers that support C++20 and Concepts is the same as the set that supports C++20, so "C++latest and Concepts" is redundant. The fact that EDG-for-STL-testing doesn't fully support C++20 is enough to rule it out of "C++latest" even absent a specific "and concepts" requirement.

@StephanTLavavej
Copy link
Member

Ok, thanks for explaining. I think we have different interpretations of what "c++latest mode" means (to me, EDG-for-STL-testing supports a /std:c++latest mode, it just happens to lack concepts support, so it's not truly conformant to either C++20 or C++23), but I'm happy to rephrase this message anyways.

@CaseyCarter
Copy link
Member Author

Ok, thanks for explaining. I think we have different interpretations of what "c++latest mode" means

I think my interpretation is actually closer to yours, I'm projecting here what I believe to be a very common customer perspective that this particular DevCom submitter represents.

@mnatsuhara mnatsuhara removed their assignment Dec 9, 2021
Copy link
Contributor

@fsb4000 fsb4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update #2061 similarly when your PR will be merged.

@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d62ead3 into microsoft:main Dec 17, 2021
@StephanTLavavej
Copy link
Member

Thanks for improving these diagnostics! 📖 💡 😸

@CaseyCarter CaseyCarter deleted the clarify_1814_message branch December 17, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants