<chrono>: Fix utc_clock seconds formatting #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional fixes for offsetting into a leap second coming, but I need to get the other PRs landed. |
Seconds were being formatted incorrectly because we incorrectly assumed that a day is 24*60*60 seconds (which is what flooring does) when in reality they aren't always (like if there was a leap second). This error compounds over time as leap seconds are inserted, so we need to add the elapsed leap seconds at any given time point to get the correct seconds. This issue doesn't affect the `tm` structure because it is constructed out of a system time (`utc_clock::to_sys`), which has 24*60*60 second days.
eldakesh-ms
force-pushed
the
cf/utc-seconds
branch
from
5e0e18e
to
d433ff7
Compare
StephanTLavavej
requested changes
Apr 20, 2021
Also fixes Clang compiler errors. Co-authored-by: MattStephanson <68978048+MattStephanson@users.noreply.github.com>
StephanTLavavej
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seconds were being formatted incorrectly because we incorrectly assumed
that a day is
24*60*60seconds (which is what flooring does) when inreality they aren't always (like if there was a leap second). This error
compounds over time as leap seconds are inserted, so we need to add the
elapsed leap seconds at any given time point to get the correct seconds.
This issue doesn't affect the
tmstructure because it is constructedout of a system time (
utc_clock::to_sys), which has24*60*60seconddays.