<chrono>: Implement exception class constructors
#1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: statementreply <statementreply@gmail.com>
We can't use floating-point durations because the exception constructors in [time.zone.exception] will stream local_time<Duration>, and [time.clock.local] implements that by streaming sys_time<Duration>, and that's constrained by [time.clock.system.nonmembers] to reject floating-point durations.
|
😱 merging without another maintainer approval. ... Wait, wasn't 2 hours ago pretty early in the morning for you? |
|
@SuperWig (catching up on my notifications) Yeah, chronat2 was a very fast-moving feature branch, no approvals needed. (We still had normal reviews before merging into main.) I'm currently on Pacific Vampire Time, so 2:47 AM is late evening for me 🧛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hh_mm_ss::hours()is already an absolute value.nonexistent_local_timeandambiguous_local_time(with a non-concepts placeholder)._STD move(_Os).str()as I believe it's equivalent and hopefully more efficient.P0355R7_calendars_and_time_zones_time_zones.local_time<Duration>, and [time.clock.local] implements that by streamingsys_time<Duration>, and that's constrained by [time.clock.system.nonmembers] to reject floating-point durations.