<format>: Assume UTF-8 format strings when execution charset is UTF-8 #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statementreply
changed the title
miscco
reviewed
Apr 11, 2021
| (void) format("{:\x9f\x8f\x88<10}"sv, 42); // Bad fill character encoding: missing lead byte before \x9f | ||
| assert(false); | ||
| } catch (const format_error&) { | ||
| } |
There was a problem hiding this comment.
We could check the error message here
There was a problem hiding this comment.
eagh, the value of checking the error messages is very low.
barcharcraz
requested changes
Apr 12, 2021
miscco
reviewed
Apr 12, 2021
stl/inc/format
Outdated
| #pragma warning(pop) | ||
| }(); | ||
|
|
||
| _NODISCARD inline int _Utf8_code_units_in_next_character(const char* const _First, const char* const _Last) noexcept { |
There was a problem hiding this comment.
from what I see nothing in this function prevents it from being constexpr
However, I believe it only makes sense at runtime. So should we add a comment that this is intentionally not constexpr
There was a problem hiding this comment.
Made it constexpr
miscco
reviewed
Apr 12, 2021
miscco
approved these changes
Apr 12, 2021
barcharcraz
approved these changes
Apr 12, 2021
tests/std/tests/P0645R10_text_formatting_legacy_text_encoding/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Apr 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When execution charset is UTF-8, assume that format strings are encoded in UTF-8, not in the active code page.
This PR only attempts to detect UTF-8.
Fixes #1820.