<memory>: Guard aligned allocation with __cpp_aligned_new #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced a couple of unguarded uses in `<memory>` in microsoft#309 "P0674R1 `make_shared` For Arrays". Fixes DevCom-1346191. Fixes AB-1283107.
CaseyCarter
changed the title
<memory>: Guard aligned allocation with __cpp_aligned_new
StephanTLavavej
approved these changes
Feb 24, 2021
joemmett
approved these changes
Feb 24, 2021
This is now #1691 - thanks @StephanTLavavej! - so we needn't discuss it here. |
|
Thanks for fixing this bug that I missed! 🙀 🪲 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a couple of unguarded uses in
<memory>in #309 "P0674R1make_sharedFor Arrays", causing breakage when users compile with/Zc:alignedNew-.Fixes DevCom-1346191.
Fixes VSO-1283107 / AB#1283107.
@microsoft/vclibs note the lack of test coverage for
/Zc:alignedNew-which (1) is necessary to validate the fix, and (2) would have caught the bug in the first place. Is it time to bite the bullet and add/Zc:alignedNew-coverage to our test matrices?