Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<memory>: Guard aligned allocation with __cpp_aligned_new #1689

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Feb 23, 2021

We introduced a couple of unguarded uses in <memory> in #309 "P0674R1 make_shared For Arrays", causing breakage when users compile with /Zc:alignedNew-.

Fixes DevCom-1346191.
Fixes VSO-1283107 / AB#1283107.

@microsoft/vclibs note the lack of test coverage for /Zc:alignedNew- which (1) is necessary to validate the fix, and (2) would have caught the bug in the first place. Is it time to bite the bullet and add /Zc:alignedNew- coverage to our test matrices?

We introduced a couple of unguarded uses in `<memory>` in microsoft#309 "P0674R1 `make_shared` For Arrays".

Fixes DevCom-1346191.
Fixes AB-1283107.
@CaseyCarter CaseyCarter added the bug Something isn't working label Feb 23, 2021
@CaseyCarter CaseyCarter requested a review from a team as a code owner February 23, 2021 16:19
@CaseyCarter CaseyCarter changed the title <memory>: Guard aligned allocation with __cpp_aligned_new <memory>: Guard aligned allocation with __cpp_aligned_new Feb 23, 2021
@CaseyCarter
Copy link
Member Author

Is it time to bite the bullet and add /Zc:alignedNew- coverage to our test matrices?

This is now #1691 - thanks @StephanTLavavej! - so we needn't discuss it here.

Copy link
Member

@MahmoudGSaleh MahmoudGSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@StephanTLavavej StephanTLavavej self-assigned this Feb 25, 2021
@StephanTLavavej StephanTLavavej merged commit 9c79c21 into microsoft:main Feb 26, 2021
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug that I missed! 🙀 🪲 🎉

@CaseyCarter CaseyCarter deleted the align_val_t branch March 17, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants