Move the suppression to the test

microsoft · Oct 10, 2023 · 55c7167 · 55c7167
1 parent 3fddbf5
commit 55c7167
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/stl/inc/xstring b/stl/inc/xstring
@@ -2730,10 +2730,7 @@ private:
 
         if constexpr (_Can_construct_by_copy) {
             const auto _Data = _My_data._Myptr();
-#pragma warning(push)
-#pragma warning(disable : 4365) // suppress the warning from signedness mismatch in assignment
             _STD _Copy_n_unchecked4(_STD move(_First), _Count, _Data);
-#pragma warning(pop)
             _My_data._Mysize = _Count;
             _Data[_Count]    = _Elem();
         } else {

diff --git a/tests/std/tests/P1206R7_string_from_range/test.cpp b/tests/std/tests/P1206R7_string_from_range/test.cpp
@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
+#pragma warning(disable : 4365) // conversion from 'X' to 'Y', signed/unsigned mismatch
+
 #include <algorithm>
 #include <array>
 #include <cassert>