Error on setting parameter if this already exists as an attribute #6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6174 +/- ##
==========================================
+ Coverage 66.11% 67.17% +1.05%
==========================================
Files 352 352
Lines 32121 32128 +7
==========================================
+ Hits 21238 21582 +344
+ Misses 10883 10546 -337 ☔ View full report in Codecov by Sentry. |
astafan8
approved these changes
Jun 27, 2024
jenshnielsen
force-pushed
the
error_on_existing_attribute
branch
from
8d209d3 to
77b1794
Compare
jenshnielsen
added a commit
to jenshnielsen/Qcodes
that referenced
this pull request
Jun 27, 2024
…_attribute Error on setting parameter if this already exists as an attribute
jenshnielsen
added a commit
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it now becomes more common for parameters to be assigned as real attributes it makes sense to also test for this
I have added a work around where a property of the same name is allowed to exist. This is done to support a known pattern where a property is added to define an interface