Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyright to 1.1.349 #5659

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jan 18, 2024

And enables most of standard type checkings

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7a35081) 67.55% compared to head (57a1850) 67.55%.
Report is 6 commits behind head on main.

Files Patch % Lines
...des/instrument_drivers/Minicircuits/USBHIDMixin.py 0.00% 2 Missing ⚠️
src/qcodes/parameters/array_parameter.py 60.00% 2 Missing ⚠️
src/qcodes/parameters/multi_parameter.py 66.66% 2 Missing ⚠️
...ers/Keysight/private/Keysight_344xxA_submodules.py 0.00% 1 Missing ⚠️
src/qcodes/utils/spyder_utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5659      +/-   ##
==========================================
- Coverage   67.55%   67.55%   -0.01%     
==========================================
  Files         348      348              
  Lines       30239    30238       -1     
==========================================
- Hits        20427    20426       -1     
  Misses       9812     9812              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen changed the title Upgrade pyright to 1.1.347 Upgrade pyright to 1.1.349 Feb 2, 2024
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 15:15 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 15:15 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 15:15 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 15:15 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 15:15 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 15:15 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen marked this pull request as ready for review February 3, 2024 10:15
@jenshnielsen jenshnielsen requested a review from a team as a code owner February 3, 2024 10:15
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 5, 2024
@jenshnielsen jenshnielsen removed this pull request from the merge queue due to a manual request Feb 5, 2024
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 5, 2024
Merged via the queue into microsoft:main with commit 7e61922 Feb 5, 2024
16 of 18 checks passed
@jenshnielsen jenshnielsen deleted the pyright_344 branch February 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants