Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for left navview getting stuck #5135

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix for left navview getting stuck #5135

merged 2 commits into from
Jul 22, 2020

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Jul 21, 2020

Summary of the Pull Request

left navview would get stuck, WinUI's newest package had the fix

References

PR Checklist

  • Applies to [settings] pressed state on items in navigationview gets stuck  #5123
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@crutkas crutkas requested a review from a team July 21, 2020 23:57
@crutkas crutkas merged commit 9dfa685 into master Jul 22, 2020
@crutkas crutkas deleted the dev/crutkas/UpdateWinUI branch July 22, 2020 18:09
@htcfreek htcfreek mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crutkas