Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT Run > Program plugin] Run commands: Support for MSC and CPL #23668

Merged
merged 7 commits into from
Feb 13, 2023
Merged

[PT Run > Program plugin] Run commands: Support for MSC and CPL #23668

merged 7 commits into from
Feb 13, 2023

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Jan 30, 2023 •
edited
Loading

Summary of the Pull Request

This PR adds support for msc files and cpl files to the "Run command" result of program plugin.

image

image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Additionally I changed he title of "Run commands" to show the file extension too.

Validation Steps Performed

Local build and unit tests.

@github-actions

This comment has been minimized.

Sign in to view
@htcfreek htcfreek self-assigned this Jan 30, 2023
@htcfreek htcfreek added Idea-Enhancement New feature or request on an existing product Run-Results (Programs) Issue with program search in PowerToys Run Needs-Review This Pull Request awaits the review of a maintainer. labels Jan 30, 2023
@htcfreek
Copy link
Collaborator Author

htcfreek commented Jan 30, 2023 •
edited
Loading

@crutkas
After I understand what is requested in the issues, it was an easy change. So here we go.
Maybe I create a second PR tomorrow to extend the Settings plugin.

@stefansjfw
If you like to have some extra tests for run commands with the extension cpl and msc please let me know how to implement them.

@htcfreek htcfreek marked this pull request as ready for review January 30, 2023 16:37
@snickler
Copy link
Collaborator

@htcfreek - this is awesome! I've been wanting this feature especially after searching for devmgmt.msc or Device Manager doesn't show the results. Thanks for doing this.

@htcfreek
Copy link
Collaborator Author

@htcfreek - this is awesome! I've been wanting this feature especially after searching for devmgmt.msc or Device Manager doesn't show the results. Thanks for doing this.

Don't know if you saw it. But there is a second PR to extend the settings plugin.

jaimecbernardo
jaimecbernardo approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works pretty nicely and the code looks good!
Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit e4e1b5b into microsoft:main Feb 13, 2023
@htcfreek htcfreek deleted the PT_ProgCplMmc branch February 13, 2023 19:42
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@htcfreek @BLM16
[PTRun][Program]Run commands: Support for MSC and CPL (microsoft#23668)
8cd0cbc 
* code changes

* spell fix

* dev docs

* update tests

* Code improvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@crutkas crutkas Awaiting requested review from crutkas

@stefansjfw stefansjfw Awaiting requested review from stefansjfw

Assignees

@htcfreek htcfreek

Labels
Idea-Enhancement New feature or request on an existing product Needs-Review This Pull Request awaits the review of a maintainer. Run-Results (Programs) Issue with program search in PowerToys Run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@htcfreek @snickler @jaimecbernardo