-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings header is not properly aligned. #9345
Comments
It is properly aligned if you look at design guidelines or the W10 Settings app. It's however the title bar that gets in the way visually since we cannot adopt the Fluent titlebar style (that allows the content to extend into the titlebar). This is a current limitation of Xaml Islands and moving to WinUI will hopefully solve this. |
I think we discussed that in #1547 @sylveon Do you have a code sample somewhere that shows how to do this? It would require to recode the minimize/maximize buttons as well. @enricogior @crutkas @dedavis6797 This would be relevant for the XAML Island in OOBE too.. |
The best reference is probably the PR to Terminal itself. This is also what I used as the basis for my implementation. |
i'd rather wait the few months for unpackaged support for WinUI 3 than do this work. Getting everything accessible and closing appropriately is a lot of custom work IMO. |
Fixed in #12470 and will be integrated in the next major release of PowerToys |
Resolved with the release of v0.45. |
ℹ Computer information
📝 Provide detailed reproduction steps (if any)
✔️ Expected result
What is the expected result of the above steps?
The settings header text should be centered in the header container.
❌ Actual result
What is the actual result of the above steps?
See screenshot below
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form
This might or might not be relevant, but i'm on 125% scaling.
The text was updated successfully, but these errors were encountered: