Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings header is not properly aligned. #9345

Closed
Tropix126 opened this issue Jan 28, 2021 · 7 comments
Closed

Settings header is not properly aligned. #9345

Tropix126 opened this issue Jan 28, 2021 · 7 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys External Dependency-WinUI 3 Dependency on WinUI Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Tropix126
Copy link

ℹ Computer information

  • PowerToys version: 0.29.3
  • PowerToy Utility: PowerToys Settings
  • Running PowerToys as Admin: No, although this isn't relevant.
  • Windows build number: 20H2 (build 19042.746)

📝 Provide detailed reproduction steps (if any)

  1. Open PowerToys settings from the system tray.
  2. Scroll to anywhere in settings.
  3. The settings header text will be offset towards the top instead of vertically centered in the container.

✔️ Expected result

What is the expected result of the above steps?
The settings header text should be centered in the header container.

❌ Actual result

What is the actual result of the above steps?
See screenshot below

📷 Screenshots

Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

image

This might or might not be relevant, but i'm on 125% scaling.

@Tropix126 Tropix126 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 28, 2021
@Tropix126 Tropix126 changed the title [Bug] Settings header is not properly aligned. Settings header is not properly aligned. Jan 28, 2021
@enricogior enricogior added Priority-3 Bug that is low priority Product-Settings The standalone PowerToys Settings application and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 28, 2021
@niels9001
Copy link
Contributor

It is properly aligned if you look at design guidelines or the W10 Settings app. It's however the title bar that gets in the way visually since we cannot adopt the Fluent titlebar style (that allows the content to extend into the titlebar).

This is a current limitation of Xaml Islands and moving to WinUI will hopefully solve this.

@enricogior enricogior added the External Dependency-WinUI 3 Dependency on WinUI label Jan 28, 2021
@sylveon
Copy link

sylveon commented Jan 28, 2021

It is possible to have a custom titlebar in XAML islands by making the window borderless and then using a child window as drag region. This is the trick used by Terminal and my app.

image

@niels9001 niels9001 added the Area-User Interface things that regard UX for PowerToys label Jan 28, 2021
@niels9001
Copy link
Contributor

I think we discussed that in #1547

@sylveon Do you have a code sample somewhere that shows how to do this? It would require to recode the minimize/maximize buttons as well.

@enricogior @crutkas @dedavis6797 This would be relevant for the XAML Island in OOBE too..

@sylveon
Copy link

sylveon commented Jan 28, 2021

The best reference is probably the PR to Terminal itself. This is also what I used as the basis for my implementation.

microsoft/terminal#5485

@crutkas
Copy link
Member

crutkas commented Jan 28, 2021

i'd rather wait the few months for unpackaged support for WinUI 3 than do this work. Getting everything accessible and closing appropriately is a lot of custom work IMO.

@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Jul 22, 2021
@niels9001 niels9001 self-assigned this Jul 22, 2021
@niels9001 niels9001 mentioned this issue Jul 22, 2021
10 tasks
@Aaron-Junker Aaron-Junker added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 23, 2021
@Aaron-Junker
Copy link
Collaborator

Fixed in #12470 and will be integrated in the next major release of PowerToys

@dedavis6797
Copy link
Contributor

Resolved with the release of v0.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys External Dependency-WinUI 3 Dependency on WinUI Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

7 participants