Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings V2 UI Task: Style WPF window titlebar so it's inline with UWP titlebar styling #1547

Closed
niels9001 opened this issue Mar 11, 2020 · 7 comments
Labels
External Dependency-WinUI 3 Dependency on WinUI Product-Settings The standalone PowerToys Settings application

Comments

@niels9001
Copy link
Contributor

Summary of the new feature/enhancement

The current WPF runner app holds a XAML island with the NavigationView. Ideally the NavigationView would flow into the title bar, like most Windows 10 apps. For this, we'd need to create a custom WPF titlebar.

Proposed technical implementation details (optional)

Create a custom styling control that holds a custom minimize, maximize and close button. Background should be transparent so the NavView can flow to the top.

Left: UWP, right: WPF
image

@mdtauk
Copy link

mdtauk commented Mar 11, 2020

Just as an aside, that "General" header, shouldn't it match the newer 10X settings style, rather than the current Settings style? (I am assuming the current settings app will get updated at some point)

ESxB1wjXkAE9Kms

EQhk9UkXUAE22Pe

ESxAW3JWkAYoIFI

@crutkas
Copy link
Member

crutkas commented Mar 12, 2020

I like the get help. I also like what Zee did with some of the styling. I think a bit more 10x flair would be nice too.

Let’s just say for right now styling matches 10x?

@crutkas crutkas added the Product-Settings The standalone PowerToys Settings application label Mar 12, 2020
@crutkas crutkas added this to the Build 2020 milestone Mar 12, 2020
@niels9001
Copy link
Contributor Author

I think following the W10X styling is a good guideline for this!

@mdtauk
Copy link

mdtauk commented Mar 12, 2020

I am sure internally there are Figma projects and other guidelines that will give you all the margin values, text sizes, weights etc you need. 😁

@crutkas
Copy link
Member

crutkas commented May 14, 2020

i don't think this is a good idea. rather do the darkmode work here for the titles and then wait for WInUI3

@crutkas
Copy link
Member

crutkas commented Dec 3, 2020

@niels9001 i don't think this will be an easy item due to the Island. I think this is just a "Migrate to WinUI 3" work item in the future.

Reopen if you disagree

@LasseRosenow
Copy link

LasseRosenow commented Sep 16, 2022

Maybe reopen now that settings ui is WinUI 3 but the titlebar still remains legacy style?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Dependency-WinUI 3 Dependency on WinUI Product-Settings The standalone PowerToys Settings application
Projects
None yet
Development

No branches or pull requests

5 participants