Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Accessibility issues related to XAML Islands (RadioButtons control + null BoundingRectangle) #6032

Closed
alekhyareddy28 opened this issue Aug 18, 2020 · 5 comments
Assignees
Labels
A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11yExternal Accessibility team tag - PT bug has external dependency A11ySev3 Accessibility team tag - P3 items A11yTTValidated Accessability team tag A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility External Dependency This bug or feature isn't resolved, but it's following an external work item. External Dependency-WinUI 3 Dependency on WinUI Issue-Bug Something isn't working PGAccepted Accessability team tag - External team accepted that issue for remediation Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Settings The standalone PowerToys Settings application Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. Status-Blocked We can't make progress due to a dependency or issue

Comments

@alekhyareddy28
Copy link
Contributor

alekhyareddy28 commented Aug 18, 2020

ℹ Computer information

  • PowerToys version:
  • PowerToy Utility:
  • Running PowerToys as Admin:
  • Windows build number: [run "winver"]

📝 Provide detailed reproduction steps (if any)

  • Run PowerToys Settings page.
  • Run the Microsoft Accessibility insights app on PT Settings.

✔️ Expected result

What is the expected result of the above steps?

  • No automated tests fail.
  • We should tab into the selected radio button (in a group of radio buttons) and be able to navigate to the other radio buttons using the arrow keys. However, this does not happen when we add the radio buttons control in xaml islands.

❌ Actual result

What is the actual result of the above steps?

  • It always tabs into the first radio button irrespective of which radio button in the group is selected.
  • Navigation using arrow keys does not work, hence making the other radio buttons inaccessible using the keyboard.

Automated tests fail because of having the DesktopWindowXAMLSource Pane.
image

📷 Screenshots

More information can be found in this issue which fixes the tab related issue by using a stackpanel instead of a radiobuttons control - #5726

Corresponding issue in the microsoft-ui-xaml repo - microsoft/microsoft-ui-xaml#3156 (regarding the XYNavigation)

Corresponding narrator issue in the microsoft-ui-xaml repo - microsoft/microsoft-ui-xaml#3183 (regarding the narrator not reading the heading)

@alekhyareddy28 alekhyareddy28 added Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Area-Accessibility Issues related to accessibility External Dependency-WinUI 3 Dependency on WinUI labels Aug 18, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 18, 2020
@crutkas crutkas added this to the InVEST-2008 milestone Aug 19, 2020
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 19, 2020
@alekhyareddy28
Copy link
Contributor Author

This issue is due to xaml islands and would no longer exist when we shift to winui 3.

@alekhyareddy28
Copy link
Contributor Author

@crutkas, I don't think we can solve it in this iteration. This issue is due to a pane being introduced by xaml islands, which does not have a property set. It is an internal pane and we cannot access it. I've added the winui-3 dependency tag. We should not have this issue anymore when we shift to winui-3. I think this should be removed from the milestone. I've created the above tracking issue (#6083) for issues which are dependent on the winui team to fix with links to issues in our repository. These issues are linked to the corresponding issue in the microsoft-ui-xaml repository.

@crutkas crutkas added External Dependency This bug or feature isn't resolved, but it's following an external work item. Status-Blocked We can't make progress due to a dependency or issue labels Aug 21, 2020
@crutkas crutkas modified the milestones: InVEST-2008, v1.0 Release Aug 21, 2020
@alekhyareddy28 alekhyareddy28 changed the title [Settings] Accessibility issues related to XAML Islands [Settings] Accessibility issues related to XAML Islands (RadioButtons control + null BoundingRectangle) Aug 21, 2020
@crutkas crutkas added A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Oct 15, 2020
@crutkas crutkas added A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft A11y-1P-WinUI 3 A11yExternal Accessibility team tag - PT bug has external dependency PGAccepted Accessability team tag - External team accepted that issue for remediation labels Feb 24, 2021
@wayvad
Copy link

wayvad commented Mar 10, 2021

Hi @alekhyareddy28 , has the null BoundingRectangle accessibility issue (revealed by Accessibility Insight) been resolved? Thanks.

@ghost ghost added A11ySev3 Accessibility team tag - P3 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines labels Jul 13, 2021
@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Jul 22, 2021
@niels9001 niels9001 self-assigned this Jul 22, 2021
@niels9001 niels9001 removed the Status-In progress This issue or work-item is under development label Aug 24, 2021
@niels9001
Copy link
Contributor

We're not longer using RadioButtons group, so closing this issue

@crutkas crutkas added the Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. label Sep 30, 2021
@ghost ghost added the A11yTTValidated Accessability team tag label Jul 12, 2022
@DhananjaySaini007
Copy link

As per the comment, the Radio buttons are no longer used and UI has changed,
Hence, closing the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11yExternal Accessibility team tag - PT bug has external dependency A11ySev3 Accessibility team tag - P3 items A11yTTValidated Accessability team tag A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility External Dependency This bug or feature isn't resolved, but it's following an external work item. External Dependency-WinUI 3 Dependency on WinUI Issue-Bug Something isn't working PGAccepted Accessability team tag - External team accepted that issue for remediation Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Settings The standalone PowerToys Settings application Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. Status-Blocked We can't make progress due to a dependency or issue
Projects
None yet
Development

No branches or pull requests

5 participants