Shortcuts don't work in PT-BR Keyboard #238
Comments
|
I've noticed the shortcut still works if you use win + " , which is the tilde's usual position for en-us keyboards. So, it's just a matter of changing the help text to reflect the user's keyboard settings. |
This is correct! Thanks! |
Well, i tried it in PT-PT keyboard and also doesn't work. |
|
For people with swedish keyboards it's win + ö |
|
For people with Danish keyboards the shortcuts is win + æ |
|
This commit 64f606d fixes the problem allowing to customize the hotkey. |
## Summary of the Pull Request This PR is ready to review with a bunch of code clean-up around shell and page initialization/navigation, progress, errors, and the back button. There's still some future items to think about, but that's beyond the scope of this work right now. See more notes in comments below on changes: > Alright, I cleaned up all the Page Initialization and Navigation code for Shell, it's all centralized there now (which makes sense) and removes 3x duplicated code we had in the ExtPage templates. They're just basic XAML controls now which don't really need to worry about how they get loaded, and just get their VMs. > > I also tidied up the massive if statement we had in ShellPage.xaml.cs for each page type so we have a singular logical flow that just branches in two statements with an inline switch for the VM constructor and the page type. > > In the future, we may want to cache some page VMs there, so if you navigate back/forth we don't reload everything... > > This also let us remove a message which was effectively just internal communication. Should be a bit cleaner now, certainly easier to add new page types now too. These are some of the last remnants of things from the original MVVM setup when we were still testing patterns and then just copied. This uses `IsInitialized` for tracking the progress bar and bubbles up errors better without blocking the app (and provides better context for errors). This also fixes the issue with the Back Button stealing focus instead of the search box (by moving it to the Shell page to leave the SearchBox control as just responsible for the searchbox/keyboard input). ------- Future Open questions/TODO: - [ ] How do we better track the parent extension/owner of pages/commands/etc... for error reporting? - [x] Need to clean-up backend logic of VMs for the loading state for the new Shell page centralization - [x] For instance, progress only happens like once now... - [x] May be able to centralize some of the loading bits logic? - [x] Finalize some brushes for error items - [ ] Still need to potentially track individual issues loading specific items, but maybe this is a good enough start for a single PR once the above are addressed? - [ ] Cache page VMs? - [ ] Clean-up async loading of pages and their content Helps with microsoft#220. This will make microsoft#238 easier as then we don't need as much XAML/Loading glue for those Co-authored-by: Niels Laute <niels.laute@live.nl> Co-authored-by: Mike Griese <zadjii@gmail.com>
Environment
Steps to reproduce
Use PT-BR keyboard layout and try to use shortcuts.
Expected behavior
Win + ~ | Launches editor
Win+Ctrl+ | Cycles through saved layouts with the coresponding number of zones
Actual behavior
Nothing
The text was updated successfully, but these errors were encountered: