Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VScode workspaces does not show up #15247

Closed
1 task
tomaxsas opened this issue Jan 4, 2022 · 12 comments
Closed
1 task

VScode workspaces does not show up #15247

tomaxsas opened this issue Jan 4, 2022 · 12 comments
Assignees
@ricardosantos9521
Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@tomaxsas
Copy link

tomaxsas commented Jan 4, 2022

Microsoft PowerToys version

0.55.1

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Install latest insiders version of vscode and try to open workspace. The location of workspaces has changed: microsoft/vscode#139632

✔️ Expected Behavior

Recently used workspaces shows up

❌ Actual Behavior

No workspaces shows up, error in log file:
`[2022-01-04 08:57:47.0077] [ERROR] [S:\src\modules\launcher\Plugins\Community.PowerToys.Run.Plugin.VSCodeWorkspaces\WorkspacesHelper\VSCodeWorkspacesApi.cs::104]
-------------------------- Begin exception --------------------------
Message: Failed to deserialize $C:\Users\zalent\AppData\Roaming\Code - Insiders\storage.json

Exception full name : System.NullReferenceException
Exception message : Object reference not set to an instance of an object.
Exception stack trace:
at Community.PowerToys.Run.Plugin.VSCodeWorkspaces.WorkspacesHelper.VSCodeWorkspacesApi.get_Workspaces()
Exception source : Community.PowerToys.Run.Plugin.VSCodeWorkspaces
Exception target site: System.Collections.Generic.List`1[Community.PowerToys.Run.Plugin.VSCodeWorkspaces.WorkspacesHelper.VSCodeWorkspace] get_Workspaces()
Exception HResult : -2147467261
-------------------------- End exception --------------------------

[2022-01-04 08:58:23.5212] [INFO] [S:\src\modules\launcher\PowerLauncher\ViewModel\MainViewModel.cs::849]
OnHotkey
`

Other Software

Version: 1.64.0-insider (user setup)
Commit: 990ad4044032b05c0ebf0f67f800c5845baad4c7
Date: 2022-01-04T05:18:15.830Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.18363
@tomaxsas tomaxsas added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 4, 2022
@franky920920
Copy link
Contributor

Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!
image

@franky920920 franky920920 added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 4, 2022
@franky920920
Copy link
Contributor

Install latest insiders version of vscode and try to open workspace. The location of workspaces has changed: microsoft/vscode#139632

Thanks for your infomation!

@tomaxsas
Copy link
Author

tomaxsas commented Jan 4, 2022

PowerToysReport_2022-01-04-09-33-32.zip

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 4, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Jan 4, 2022

cc: @ricardosantos9521

@ricardosantos9521
Copy link
Contributor

I will take a look at this tomorrow.

@crutkas
Copy link
Member

crutkas commented Jan 4, 2022

@ricardosantos9521 this is 0.51.1 so it wouldn't include the two fixes you just did with 0.53. Do you think 53 has the fix?

@crutkas crutkas removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Jan 4, 2022
@ricardosantos9521
Copy link
Contributor

ricardosantos9521 commented Jan 4, 2022 •
edited
Loading

@ricardosantos9521 this is 0.51.1 so it wouldn't include the two fixes you just did with 0.53. Do you think 53 has the fix?

No 53 doesn't have the fix. They moved the opened workspaces from settings.json to Backup/workspaces.json in vscode insiders. This will not impact previous versions of vscode stable until the next release.

@ricardosantos9521 ricardosantos9521 mentioned this issue Jan 5, 2022
Merged
10 tasks
ricardosantos9521 added a commit to ricardosantos9521/PowerToys that referenced this issue Jan 5, 2022
@ricardosantos9521
microsoft#15247 Powertoys Run | VSCodeWorkspaces- add support for vsc…
580d803 
…ode 1.64 new workspace.json file
@crutkas crutkas added the Status-In progress This issue or work-item is under development label Jan 5, 2022
@hectormz
Copy link

Glad to see this already exists. I came to open an issue.
Seems to have broken the behavior between 1.59.0 and 1.64.0 of VSCode Insider

ricardosantos9521 added a commit to ricardosantos9521/PowerToys that referenced this issue Jan 15, 2022
@ricardosantos9521
microsoft#15247 Powertoys Run | VSCodeWorkspaces- add support for vsc…
cc406f8 
…ode 1.64 new workspace.json file
ricardosantos9521 added a commit to ricardosantos9521/PowerToys that referenced this issue Jan 18, 2022
@ricardosantos9521
microsoft#15247 Powertoys Run | VSCodeWorkspaces- add support for vsc…
6fad85d 
…ode 1.64 new workspace.json file
ricardosantos9521 added a commit to ricardosantos9521/PowerToys that referenced this issue Jan 18, 2022
@ricardosantos9521
microsoft#15247 Powertoys Run | VSCodeWorkspaces- add support for vsc…
3f64c77 
…ode 1.64 new workspace.json file
@stefansjfw stefansjfw removed the Status-In progress This issue or work-item is under development label Jan 18, 2022
@stefansjfw stefansjfw added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 18, 2022
@franky920920 franky920920 reopened this Jan 18, 2022
@franky920920
Copy link
Contributor

@Aaron-Junker / @stefansjfw Cloud you update the project? Thanks!

@stefansjfw
Copy link
Collaborator

stefansjfw commented Jan 18, 2022 •
edited
Loading

done. Not sure how I closed this. It was a mistake. Thanks for reopening

@franky920920
Copy link
Contributor

@stefansjfw Because commit message of 758a21a includes fix #15247 so GitHub closed this automatically.
See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@crutkas
Copy link
Member

crutkas commented Jan 31, 2022

The was fixed in in 0.55. Head over to https://aka.ms/installpowertoys to try it out

@crutkas crutkas closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardosantos9521 ricardosantos9521

Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@crutkas @franky920920 @tomaxsas @ricardosantos9521 @hectormz @stefansjfw @htcfreek