Enable PowerApps MDA Classic Input controls for Custom Pages with Test Engine Support #501
Conversation
|
#436 is the work item |
v-raghulraja
changed the title
| var trueDateTime = new DateTime(1970, 1, 1, 0, 0, 0).AddMilliseconds(milliseconds); | ||
| var dateTimeOffset = DateTimeOffset.FromUnixTimeMilliseconds(milliseconds); | ||
| DateTime trueDateTime = dateTimeOffset.LocalDateTime; | ||
| //var trueDateTime = new DateTime(1970, 1, 1, 0, 0, 0).AddMilliseconds(milliseconds); |
There was a problem hiding this comment.
Remove commented out line. Since seems like it is not needed, and this variable has been defined and initialized one line above.
| @@ -208,11 +208,17 @@ public string CheckTestEngineObject | |||
| { | |||
| case "disabled": | |||
| case "visible": | |||
| case "checked": | |||
| return (T)(object)("{PropertyValue: " + value.ToString().ToLower() + "}"); | |||
| default: | |||
| switch (value.GetType().ToString()) | |||
| { | |||
| case "System.String": | |||
There was a problem hiding this comment.
I wonder if nameof(System.String) works properly here instead.
There was a problem hiding this comment.
The nameof(System.String) approach won't work here because it evaluates to "String" instead of the fully qualified type name "System.String". Since value.GetType().ToString() returns the fully qualified type name, using nameof would cause a mismatch. Consider using value is string for a cleaner and more type-safe approach.
| @@ -479,7 +485,7 @@ public async Task<bool> SetPropertyDateAsync(ItemPath itemPath, DateValue value) | |||
| // TODO - Set the Xrm SDK Value and update state for any JS to run | |||
There was a problem hiding this comment.
Is this // TODO comment still valid. Or can we remove it. This type of TODO comments (Tasks), is usually not useful, and I would prefer to have a work-item if something is missing to implement here.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist