Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/reference copy #2046

Merged
merged 10 commits into from
Jan 21, 2025
Merged

fix/reference copy #2046

merged 10 commits into from
Jan 21, 2025

Conversation

baywet
Copy link
Member

@baywet baywet commented Jan 8, 2025

partial #1998

@baywet baywet self-assigned this Jan 8, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2025
View reviewed changes
src/Microsoft.OpenApi/Services/CopyReferences.cs
{
internal class CopyReferences : OpenApiVisitorBase
private readonly OpenApiDocument _target = target;
public OpenApiComponents Components = new();

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'Components' can be 'readonly'.
@baywet baywet added this to the v2 - preview5 milestone Jan 8, 2025
@baywet
Copy link
Member Author

baywet commented Jan 17, 2025

@MaggieKimani1 I just had a thought: we could define a generic IOpenApiReferenceable interface, that derives from the existing interface, and defines the target property. Thoughts?

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 I just had a thought: we could define a generic IOpenApiReferenceable interface, that derives from the existing interface, and defines the target property. Thoughts?

Yeah this seems like a cleaner approach for designing the proxy classes. Let me implement this.

@MaggieKimani1 MaggieKimani1 marked this pull request as ready for review January 20, 2025 17:10
@baywet baywet enabled auto-merge January 20, 2025 20:17
@baywet
Copy link
Member Author

baywet commented Jan 20, 2025

@MaggieKimani1 since I created this PR, I can't approve it, but I'm happy with the current content.
I think you can approve and merge it.

Also, when that is done, can you put together a release PR please? (bump preview versions)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@baywet baywet merged commit 995528e into dev Jan 21, 2025
13 of 14 checks passed
@baywet baywet deleted the fix/reference-copy branch January 21, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaggieKimani1 MaggieKimani1 MaggieKimani1 approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
v2 - preview5
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @MaggieKimani1