fix/json node serialization #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
baywet
commented
Jan 2, 2025
baywet
commented
- ci: updates main with the latest ci changes
- fix: removes extraneous download artifact task
- fix: hidi GH release
- fix: redundant artifact upload
- fix: removes actions steps that create extraneous tags
- fix: updates output syntax for tag version
- ci: moves create github release to its own job
- nit: fixes indent
- fix: reverts to a regular variable for the tag value
- ci: fix artefacts path
- fix: date time and date time offset shifting zones perf: avoid round trip serialization
Release libs.
Releases Hidi
Released Hidi
Release Hidi lib.
Release Hidi
V2-preview1 release
Release hidi
Release hidi and libs
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
ci: updates main with the latest ci changes
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
fix/ci hidi gh upload to main
release of preview 3
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
fix/ci tag value to main
perf: avoid round trip serialization Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng,
MaggieKimani1 and
andrueastman
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
andrueastman
approved these changes
Jan 3, 2025
|
|
||
| if (node == null) | ||
| { | ||
| writer.WriteNull(); | ||
| return; | ||
| } | ||
|
|
||
| var element = JsonDocument.Parse(node.ToJsonString()).RootElement; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.