Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/reference proxy single copy #2031

Merged
merged 15 commits into from
Jan 7, 2025
Merged

fix/reference proxy single copy #2031

merged 15 commits into from
Jan 7, 2025

Conversation

baywet
Copy link
Member

@baywet baywet commented Dec 27, 2024

partial #1998

@baywet
fix: single copy and maintain for references
30ee6ed 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: uses backing fields instead of schema copy
6f4e7a2 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet self-assigned this Dec 27, 2024
baywet added 10 commits December 30, 2024 09:29
@baywet
chore: linting
0a7b4f6 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
feat: adds components registration method for schemas
10e548a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
72db982 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
feat; adds a method to register and add the component schemas
efd2bfb 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: null propagation for most failed reference lookup
7994691 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: aligns missing properties for override
e3325b9 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: aligns to null propagation operator
8d57b81 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: updates public api file
b727581 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
5b4c94e 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
e366566 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: linting
a231748 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
fix: adds support for all component types
8a73b54
@baywet baywet marked this pull request as ready for review January 6, 2025 17:50
@baywet baywet enabled auto-merge January 6, 2025 17:50
@baywet
chore: updates public api test
45d49f1 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
45.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@baywet baywet merged commit 1394da7 into dev Jan 7, 2025
11 of 12 checks passed
@baywet baywet deleted the fix/reference-proxy-single-copy branch January 7, 2025 15:06
@baywet baywet added this to the v2 - preview5 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaggieKimani1 MaggieKimani1 MaggieKimani1 approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
v2 - preview5
Development

Successfully merging this pull request may close these issues.
3 participants
@baywet @darrelmiller @MaggieKimani1