Feature/plugin #1258
Merged
Feature/plugin #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrelmiller
requested review from
irvinesunday,
peombwa,
zengin,
baywet,
millicentachieng,
MaggieKimani1 and
andrueastman
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@darrelmiller there are 16 code smells on your PR. Would you mind doing a cleanup pass before we review please? |
Comment on lines
+37
to
+46
| catch (Exception ex) | ||
| { | ||
| #if DEBUG | ||
| logger.LogCritical(ex, "Command failed"); | ||
| throw; // so debug tools go straight to the source of the exception when attached | ||
| #else | ||
| logger.LogCritical(ex.Message); | ||
| return 1; | ||
| #endif | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
|
@baywet I got it down to 3 smells and they are not too smelly. |
MaggieKimani1
previously approved these changes
Jun 9, 2023
baywet
requested changes
Jun 9, 2023
src/Microsoft.OpenApi.Hidi/Extensions/OpenApiExtensibleExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Merged
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
baywet
approved these changes
Jun 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a preview plugin command to enable generating OpenAI plugin manifests from an API Manifest file.
Adds a languageFormat property to settings to enable generating "PowerShell" style OpenAPI from CSDL.