Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize OpenApiDate values properly to short date #1102

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

irvinesunday
Copy link
Contributor

Fixes #1101

This PR:

  • Serializes OpenApiDate values to short date.
  • Updates test to validate the above.

baywet
baywet previously approved these changes Dec 6, 2022
Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail
@irvinesunday irvinesunday dismissed stale reviews from millicentachieng and baywet via df68816 December 8, 2022 07:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@irvinesunday irvinesunday enabled auto-merge (squash) December 8, 2022 07:58
@irvinesunday irvinesunday merged commit 1a7392f into vnext Dec 8, 2022
@irvinesunday irvinesunday deleted the is/fix-date-serialization branch December 8, 2022 12:03
Afsalmc pushed a commit to Afsalmc/OpenAPI.NET that referenced this pull request Dec 14, 2022
* Serialize OpenApiDate properly as Date

* Change test date value

Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail
MaggieKimani1 added a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenApiDate values are serialized as DateTime with timestamps
3 participants