feat!: improve hyperkzg api #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
force-pushed
the
feat/improve-hyperkzg-api
branch
from
d09c9da to
74b783e
Compare
This makes the transcript more compatible with the EVM, which is big-endian
This is accomplished via `new` and `into_inner` methods
This is accomplished via `com`, `w`, and `v` accessors.
This can be used instead of `CommitmentEngineTrait::setup` to generate a reproducible commitment key
JayWhite2357
force-pushed
the
feat/improve-hyperkzg-api
branch
from
74b783e to
26cd4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
There are a few things in hyperkzg that make upstream usage impossible or difficult. In particular, the actual proof is inaccessible in a transparent fashion.
Changes
Take a look at the individual commits.
newandinto_innermethodscom,w, andvaccessors.setup_from_rngfor hyperkzg::CommitmentKeyCommitmentEngineTrait::setupto generate a reproducible commitment key