Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @srinathsetty,
This PR implements the folding scheme for R1CS from the NeutronNova paper.
The full protocol has been implemented, although there are still improvements to be made. I would appreciate a review from you first to ensure the PR is heading in the right direction before I proceed with the enhancements.
The improvements to be addressed are:
Keccak
transcript withPoseidonRO
, enabling the implementation of a verifier circuit. (I usedkeccak
for the initial review becuase the main annoyance I encountered is that theRO
only allows one squeeze perRO
instantiation. I would appreciate your input on whether we can modify this behavior.)Sumfold
prover implementation, but I'll wait to batch the Sumfold instances first. ASumFoldEngine
trait may be useful here.__
The test is in this file
src/neutron_nova/tests
cargo test --lib -- neutron_nova::tests::test_tiny_r1cs_bellpepper
Thanks!