fix: Remove Createdby Parameter from deploy.yml and change logic in bicep #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes minor adjustments to deployment configuration, specifically around the handling of the
createdBy
metadata in both the deployment workflow and infrastructure code. The changes improve how thecreatedBy
value is set, making it more robust and context-aware.Deployment metadata improvements:
In
.github/workflows/deploy.yml
, thecreatedBy
environment variable is no longer set during the deployment job, likely to avoid redundancy or potential confusion.In
infra/main.bicep
, the logic for setting thecreatedBy
parameter has been improved: it now uses the username if available, otherwise it falls back to the deployer's object ID, ensuring the field is always populated with meaningful information....
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information