This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Merge dev into master #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After injecting the `Signaler` dependency into `PeerConnection`, ensure that `PeerConnection` uses `Signaler` directly to send messages to the remote peer, and listens to incoming ones. This allows sharing the logic between the Unity intergration and any other C# app like the WPF test app. NB: This temporarily injects some dependency to node-dss, which shall be removed later.
Signaler is now notified by the PeerConnection directly when messages need to be sent, so stop listening to the PeerConnection events and react to them.
Ensure that calls to `SendMessageAsync()` enqueue an action to be executed in the main UI thread, and ensure that the `Task` object returned will wait for the coroutine to finish.
Unity objects can only be accessed from the main Unity thread where scripts are running. Fire Unity events from this thread so that the listener's handler can directly access Unity objects.
Change all interop calls to use the `stdcall` calling convention, because Unity's IL2CPP does not understand the `CallingConvention` C# attribute and will unconditionally transpile delegates to C functions with `stdcall` calling convention. Note that this is only an issue for x86.
Mixed Reality Capture (MRC) is only available in 2 contexts: - In exclusive-mode apps, the application has access to its own rendering only. This is always available. - In shared-mode apps (2D slate), the application requires a restricted capability `screenDuplication`, which is not available to third-party apps. Therefore in order to allow using MRC from the sample app in a general context, using exclusive mode is required. This is achieved by enabling VR support (Windows Mixed Reality) in the Unity player settings.
...WebRTC.Unity/Assets/Microsoft.MixedReality.WebRTC.Unity/Scripts/Signaling/NodeDssSignaler.cs
Outdated
Show resolved
Hide resolved
stephenatwork
approved these changes
Jun 21, 2019
Avoid scanning the individual C# files in addition of the .csproj, which already references the same files. This prevents warnings about duplicate types found in the C# file and [empty-string], which is in addition very confusing as an error message for the user.
Add an `Ms` prefix to time variables storing milliseconds for clarity. Fix the implementation of `Enqueue(ARGB)` after the I420 variant. Add comments where they're missing.
This was referenced Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest changes and fixes to
master:GetVideoCaptureDevicesAsync()VideoChatDemoby changing to exclusive mode app