This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Fix issues with frame ready callbacks #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cases where both I420A and ARGB32 callbacks are used.
Registering a callback with the interop library triggers the conversion of every frame from the native format into the one the callback wants, which is very expensive and should be done only when needed. This also fixes a deadlock caused by subscription and frame-ready event trying to acquire the callback lock and the WebRTC worker thread at the same time. Fixes microsoft#151.
djee-ms
approved these changes
Jul 29, 2020
tests/Microsoft.MixedReality.WebRTC.Tests/LocalVideoTrackTests.cs
Outdated
Show resolved
Hide resolved
They can cause deadlocks and the only side effect of removing them is that a handler may be called once (at most) after it has been removed. This is an issue with any free-threaded C# event, so users should be aware of this and handle any necessary synchronization. Otherwise for consistency we should implement this pattern in all our free-threaded events which would be impractical.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151, a deadlock caused by subscription and frame-ready event trying to acquire the callback lock and the WebRTC worker thread at the same time, wrong behavior when using both I420A and ARGB32 callbacks, and a non-compiling test.