This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Remove abstraction of ExternalVideoTrackSource #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the internal abstraction of the ExternalVideoTrackSource class, which used to exhibit a clean C++ interface but has no reason to be now that only a pure C interop API is exported. This simplifies the internal implementation by removing a level of indirection.
fibann
reviewed
Jun 2, 2020
| @@ -15,6 +15,47 @@ namespace WebRTC { | |||
|
|
|||
| class ExternalVideoTrackSource; | |||
|
|
|||
| namespace detail { | |||
|
|
|||
| /// Adapater for the frame buffer of an external video track source, | |||
There was a problem hiding this comment.
Suggested change
| /// Adapater for the frame buffer of an external video track source, | |
| /// Adapter for the frame buffer of an external video track source, |
There was a problem hiding this comment.
I like "Adapater" though... ;)
fibann
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the internal abstraction of the ExternalVideoTrackSource class,
which used to exhibit a clean C++ interface but has no reason to be now
that only a pure C interop API is exported. This simplifies the internal
implementation by removing a level of indirection.