This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Add split audio track source #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the audio track source from the audio track, to allow sharing across peer connections. This change splits the former local audio track into 2 separate components: - The audio track source, which generates the raw audio frames, generally from a local audio capture device (microphone) but not necessarily. At this time only device-based sources are supported though. The audio track source is not associated with any peer connection in particular, and can be shared amongst any number of local audio tracks, from the same peer connection or not. - The local audio track, which is associated with a particular peer connection, and which is a slim bridge between an audio track source and the audio transceiver of the peer connection.
djee-ms
added
enhancement
fibann
reviewed
May 25, 2020
fibann
reviewed
May 25, 2020
fibann
reviewed
May 25, 2020
fibann
reviewed
May 25, 2020
Comment on lines
44
to
45
| // TODO(tommi): This method should be on the track and ideally volume should | ||
| // be applied in the track in a way that does not affect clones of the track. |
fibann
approved these changes
May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the audio track source from the audio track, to allow sharing
across peer connections.
This change splits the former local audio track into 2 separate
components:
generally from a local audio capture device (microphone) but not
necessarily. At this time only device-based sources are supported
though. The audio track source is not associated with any peer
connection in particular, and can be shared amongst any number of
local audio tracks, from the same peer connection or not.
connection, and which is a slim bridge between an audio track source
and the audio transceiver of the peer connection.
This change adds support to the native and C# libraries only.