This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Add multi-track support to C# library via transceiver API #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the change in the interop DLL.
Callbacks from native code (reverse P/Invoke) are invoked on the signaling thread and should not call into the native WebRTC API again. For the RenegotiationNeeded event, since it is common for the user to call CreateOffer() as a result of this event, move its call to a worker thread. In addition, delay the call until the C# Transceiver wrapper has been fully constructed (and its handle set) to avoid invoking an event with a partially-constructed object.
Wait until the SDP exchange is completed to continue testing, otherwise some RenegotiationNeeded event or other might be invoked due to SetRemoteDescription() in parallel of another call due to setting a transceiver direction, among other issues.
fibann
reviewed
Mar 12, 2020
Comment on lines
+558
to
+559
| // Cannot run in UI thread on UWP because this will initialize the global factory | ||
| // (first library call) which needs to be done on a background thread. |
There was a problem hiding this comment.
nit: not for this review, but this looks like a very easy pitfall, it might be better to have an explicit initialization call instead.
There was a problem hiding this comment.
Yes, although explicit call is quite tricky in Unity
fibann
reviewed
Mar 12, 2020
libs/Microsoft.MixedReality.WebRTC/Interop/RemoteAudioTrackInterop.cs
Outdated
Show resolved
Hide resolved
fibann
reviewed
Mar 12, 2020
fibann
reviewed
Mar 12, 2020
fibann
reviewed
Mar 12, 2020
fibann
reviewed
Mar 13, 2020
fibann
reviewed
Mar 13, 2020
fibann
reviewed
Mar 13, 2020
fibann
reviewed
Mar 16, 2020
Media tracks attached to the peer connection are those tracks attached to an owned transceiver, so can be enumerated from them. This simplifies the implementation and avoid the need to keep track of those tracks explicitly.
Rely on peer connection callbacks during Close() to clean-up the remote tracks. Also fix a bug where those callbacks are fired after the tracks have been destroyed.
- Fix bug in implementation passing the wrong address as the data channel object handle, which results in stack corruption of the managed engine. - Drive data channel clean-up from the DataChannelRemoved callback, whether invoked from the user removing a data channel or from a data channel being removed/destroyed automatically by the implementation.
fibann
reviewed
Mar 16, 2020
libs/Microsoft.MixedReality.WebRTC.Native/src/peer_connection.cpp
Outdated
Show resolved
Hide resolved
fibann
reviewed
Mar 16, 2020
This is redundant with the Transceiver.DesiredDirection setter.
Like remote tracks, data channels are essentially owned by the peer connection, even if the user can manually initiate creation. Therefore make DataChannel a regular non-disposable class to avoid confusion with implementation destroying a data channel.
fibann
reviewed
Mar 18, 2020
| } | ||
|
|
||
| internal void Destroy() | ||
| internal void DestroyNative() |
There was a problem hiding this comment.
The call to GC.SuppressFinalize is unnecessary now, right?
fibann
approved these changes
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2/N of the multi-track support : C# library. See part 1 (interop; #202) for an overall description of the API changes.
Bug: #152