This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Fix data channel before connect #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the SCTP negotiating is only preventing `AddDataChannelAsync` after the connection started, and not before, which is the only way to effectively ensure it occurs.
This was referenced Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that data channel can be created after the peer connection is initialized but before starting the SDP connection handshake, so that the later can integrate SCTP handshake. Otherwise there is no way to use data channels.
Return some error codes from C/C++ and transform those into exceptions in C#. This fixes a NULL pointer dereferencing in
TestAppUWP, which only handles exceptions.