Updates for scripts 1 and 2

[mrbodean]

Added error checking and moved some functions from the script to a functions script to reduce some of the code duplication. Added -verbose option and appending to log files.
Accept or reject, I am just sharing.

[jaromirk]

Really cool! Ill take a look more in depth as ill get to pc. Thx!

[jaromirk]

I reviewed it, cool! Can you send more functions to functions.ps1? Also from 3_deploy? I'll test it next week and most probably merge it. This is really what I needed as I'm new to scripting..

[mrbodean]

Sure, Glad to help out. This really helps me rebuild my labs for experimentation.

[jaromirk]

I plan change in deploy to support better win 2012 r2 clusters (specify multiple shared disks), so function would really help.

From: Jon aka @mrbodean [mailto:notifications@github.com]
Sent: Thursday, May 5, 2016 11:19 PM
To: Microsoft/ws2016lab ws2016lab@noreply.github.com
Cc: Jaromir Kaspar jaromirk@microsoft.com; Comment comment@noreply.github.com
Subject: Re: [Microsoft/ws2016lab] Updates for scripts 1 and 2 (#2)

Sure, Glad to help out. This really helps me rebuild my labs for experimentation.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-217283100

[MS-MatthewWalker]

you can review https://github.com/PlagueHO/LabBuilder for ideas on functions

[MS-MatthewWalker]

Also do you want to do more work or go ahead and commit the changes?

[jaromirk]

Hey all, I tested it and it crashes when running scripts is disabled on system (defaults). Ill hold merge and will take a look deeper and with Matt we will work on merging the ideas (I like separate functions.ps1 but not sure as I like as few files as possible., I'd like to discuss write-output as it does not produce color output- I like solutions as simple as possible and there are just few duplicates (one answer file and elevation ... Can you take a look into how to rewrite creating vm in 3_deploy) thx!

[jaromirk]

Hi! I just ran thru the changes. I keep functions in the scripts and I kept write-host instead of write-output (or error/info) as this is interactive script and I want to show colored output. I grabbed some ideas. THX!