Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Artifact defaults when using built-in #567

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

AndyGerlicher
Copy link
Member

No description provided.

@dfederm
Copy link
Member

dfederm commented Sep 10, 2024

My preferred change would be to change:

<EnableArtifacts Condition="'$(UseArtifactsOutput)' == 'true'">false</EnableArtifacts>

To:

<EnableDefaultArtifacts Condition="'$(UseArtifactsOutput)' == 'true'">false</EnableDefaultArtifacts>

and I guess move it from Microsoft.Build.Artifacts.Common.props to Microsoft.Build.Artifacts.props.

The "artifacts output layout" really just redirects the default outputs to a repo-rooted location. It doesn't solve the problem of arbitrary copies. So IMO only the default artifacts should be disabled, ie the implicit <Artifact Include="$(OutputPath)" DestinationFolder="$(ArtifactsPath)" />. Any explicit Artifact or Robocopy items should still be respected.

dfederm
dfederm previously approved these changes Sep 24, 2024
@AndyGerlicher AndyGerlicher changed the title Add condition to always turn on RobocopyFiles Better Artifact defaults when using built-in Sep 24, 2024
@AndyGerlicher AndyGerlicher enabled auto-merge (squash) September 24, 2024 22:52
@AndyGerlicher AndyGerlicher merged commit b48779f into main Sep 25, 2024
5 checks passed
@AndyGerlicher AndyGerlicher deleted the dev/robocopy branch September 25, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants