Pass in properties for inner build targets #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `Clean`, `Test` and `VSTest` targets exist in inner builds, we should pass in properties that `ResolveProjectReferences` in Common.targets passes in as well. The Build and GetTargetPath targets already do so but the above listed targets don't which causes unnecessary clean and test invocations when a specific target framework is set.
jeffkl
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
Clean,TestandVSTesttargets exist in inner builds, we should pass in properties thatResolveProjectReferencesin Common.targets passes in as well. The Build and GetTargetPath targets already do so but the above listed targets don't which causes unnecessary clean and test invocations when a specific target framework is set.cc @jeffkl @ericstj