PR Feedback

microsoft · Jul 16, 2020 · a9a99d9 · a9a99d9
1 parent 838a99e
commit a9a99d9
Showing 1 changed file with 1 addition and 86 deletions.
diff --git a/src/Traversal/Sdk/Sdk.targets b/src/Traversal/Sdk/Sdk.targets
@@ -105,6 +105,7 @@
   <PropertyGroup>
     <BuildInParallel Condition="'$(BuildInParallel)' == ''">true</BuildInParallel>
     <ContinueOnError Condition="'$(ContinueOnError)' == ''">false</ContinueOnError>
+    <StopOnFirstFailure Condition="'$(StopOnFirstFailure)' == ''">true</StopOnFirstFailure>
   </PropertyGroup>
 
   <Target Name="PrepareForBuild"
@@ -114,17 +115,6 @@
           DependsOnTargets="$(BuildDependsOn)"
           Condition=" '$(IsGraphBuild)' != 'true' "
           Returns="@(CollectedBuildOutput)">
-
-    <ItemGroup>
-      <_buildInParallel Remove="@(_buildInParallel)" />
-      <_buildInParallel Include="$([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)', '$(BuildInParallel)'))" />
-    </ItemGroup>
-
-    <PropertyGroup Condition="'$(StopOnFirstFailure)' == '' or '$(StopOnFirstFailure)' == 'true'">
-      <StopOnFirstFailure>false</StopOnFirstFailure>
-      <StopOnFirstFailure Condition="!@(_buildInParallel->AnyHaveMetadataValue('Identity', 'true'))">true</StopOnFirstFailure>
-    </PropertyGroup>
-
     <MSBuild Projects="@(ProjectReference)"
              Condition="'%(ProjectReference.Build)' != 'false'"
              BuildInParallel="$([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)', '$(BuildInParallel)'))"
@@ -139,21 +129,6 @@
   <Target Name="Clean"
           DependsOnTargets="$(CleanDependsOn)"
           Condition=" '$(IsGraphBuild)' != 'true' ">
-
-    <ItemGroup>
-      <_buildInParallel Remove="@(_buildInParallel)" />
-      <_buildInParallel Include="$([MSBuild]::ValueOrDefault('%(ProjectReference.CleanInParallel)',
-                                  $([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)',
-                                    $([MSBuild]::ValueOrDefault('$(CleanInParallel)', '$(BuildInParallel)'))
-                                    ))
-                                  ))" />
-    </ItemGroup>
-
-    <PropertyGroup Condition="'$(StopOnFirstFailure)' == '' or '$(StopOnFirstFailure)' == 'true'">
-      <StopOnFirstFailure>false</StopOnFirstFailure>
-      <StopOnFirstFailure Condition="!@(_buildInParallel->AnyHaveMetadataValue('Identity', 'true'))">true</StopOnFirstFailure>
-    </PropertyGroup>
-
     <MSBuild Projects="@(ProjectReference)"
              Targets="Clean"
              Condition="'%(ProjectReference.Clean)' != 'false'"
@@ -171,21 +146,6 @@
   <Target Name="Test"
           DependsOnTargets="$(TestDependsOn)"
           Condition=" '$(IsGraphBuild)' != 'true' ">
-
-    <ItemGroup>
-      <_buildInParallel Remove="@(_buildInParallel)" />
-      <_buildInParallel Include="$([MSBuild]::ValueOrDefault('%(ProjectReference.TestInParallel)',
-                                  $([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)',
-                                    $([MSBuild]::ValueOrDefault('$(TestInParallel)', '$(BuildInParallel)'))
-                                    ))
-                                  ))" />
-    </ItemGroup>
-
-    <PropertyGroup Condition="'$(StopOnFirstFailure)' == '' or '$(StopOnFirstFailure)' == 'true'">
-      <StopOnFirstFailure>false</StopOnFirstFailure>
-      <StopOnFirstFailure Condition="!@(_buildInParallel->AnyHaveMetadataValue('Identity', 'true'))">true</StopOnFirstFailure>
-    </PropertyGroup>
-
     <MSBuild Projects="@(ProjectReference)"
              Targets="Test"
              Condition="'%(ProjectReference.Test)' != 'false'"
@@ -203,21 +163,6 @@
   <Target Name="VSTest"
           DependsOnTargets="$(VSTestDependsOn)"
           Condition=" '$(IsGraphBuild)' != 'true' ">
-
-    <ItemGroup>
-      <_buildInParallel Remove="@(_buildInParallel)" />
-      <_buildInParallel Include="$([MSBuild]::ValueOrDefault('%(ProjectReference.TestInParallel)',
-                                  $([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)',
-                                    $([MSBuild]::ValueOrDefault('$(TestInParallel)', '$(BuildInParallel)'))
-                                    ))
-                                  ))" />
-    </ItemGroup>
-
-    <PropertyGroup Condition="'$(StopOnFirstFailure)' == '' or '$(StopOnFirstFailure)' == 'true'">
-      <StopOnFirstFailure>false</StopOnFirstFailure>
-      <StopOnFirstFailure Condition="!@(_buildInParallel->AnyHaveMetadataValue('Identity', 'true'))">true</StopOnFirstFailure>
-    </PropertyGroup>
-
     <MSBuild Projects="@(ProjectReference)"
              Targets="VSTest"
              Condition="'%(ProjectReference.Test)' != 'false'"
@@ -235,21 +180,6 @@
   <Target Name="Pack"
           DependsOnTargets="$(PackDependsOn)"
           Condition=" '$(IsGraphBuild)' != 'true' ">
-
-    <ItemGroup>
-      <_buildInParallel Remove="@(_buildInParallel)" />
-      <_buildInParallel Include="$([MSBuild]::ValueOrDefault('%(ProjectReference.PackInParallel)',
-                                  $([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)',
-                                    $([MSBuild]::ValueOrDefault('$(PackInParallel)', '$(BuildInParallel)'))
-                                    ))
-                                  ))" />
-    </ItemGroup>
-
-    <PropertyGroup Condition="'$(StopOnFirstFailure)' == '' or '$(StopOnFirstFailure)' == 'true'">
-      <StopOnFirstFailure>false</StopOnFirstFailure>
-      <StopOnFirstFailure Condition="!@(_buildInParallel->AnyHaveMetadataValue('Identity', 'true'))">true</StopOnFirstFailure>
-    </PropertyGroup>
-
     <MSBuild Projects="@(ProjectReference)"
              Targets="Pack"
              Condition="'%(ProjectReference.Pack)' != 'false'"
@@ -267,21 +197,6 @@
   <Target Name="Publish"
           DependsOnTargets="$(PublishDependsOn)"
           Condition=" '$(IsGraphBuild)' != 'true' ">
-
-    <ItemGroup>
-      <_buildInParallel Remove="@(_buildInParallel)" />
-      <_buildInParallel Include="$([MSBuild]::ValueOrDefault('%(ProjectReference.PublishInParallel)',
-                                  $([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)',
-                                    $([MSBuild]::ValueOrDefault('$(PublishInParallel)', '$(BuildInParallel)'))
-                                    ))
-                                  ))" />
-    </ItemGroup>
-
-    <PropertyGroup Condition="'$(StopOnFirstFailure)' == '' or '$(StopOnFirstFailure)' == 'true'">
-      <StopOnFirstFailure>false</StopOnFirstFailure>
-      <StopOnFirstFailure Condition="!@(_buildInParallel->AnyHaveMetadataValue('Identity', 'true'))">true</StopOnFirstFailure>
-    </PropertyGroup>
-
     <MSBuild Projects="@(ProjectReference)"
              Properties="$(TraversalPublishGlobalProperties)"
              Targets="Publish"