Skip to content

Commit

Permalink
Use CopyOnWrite 0.3.10 (#569)
Browse files Browse the repository at this point in the history
* Use CopyOnWrite 0.3.9

Consume the fix published in https://github.com/microsoft/CopyOnWrite/pull/45/files

* Update Directory.Packages.props

* Fix the tests
  • Loading branch information
stan-sz authored Sep 24, 2024
1 parent 3240393 commit 947e614
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
5 changes: 3 additions & 2 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@
<MicrosoftBuildPackageVersion>17.8.3</MicrosoftBuildPackageVersion>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="CopyOnWrite" Version="0.3.8" Condition=" '$(TargetFramework)' != 'net46' " />
<PackageVersion Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildPackageVersion)" />
<PackageVersion Include="CopyOnWrite" Version="0.3.10" Condition=" '$(TargetFramework)' != 'net46' " />
<PackageVersion Include="Microsoft.Build" Version="$(MicrosoftBuildPackageVersion)" />
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildPackageVersion)" />
<PackageVersion Include="Microsoft.Win32.Registry" Version="5.0.0" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="System.CodeDom" Version="8.0.0" />
<PackageVersion Include="System.Collections.Immutable" Version="7.0.0" />
<PackageVersion Include="System.Text.Json" Version="8.0.4" />
<PackageVersion Include="System.Threading.Tasks.Dataflow" Version="7.0.0" Condition=" '$(TargetFramework)' != 'net46' " />
<PackageVersion Include="System.Threading.Tasks.Dataflow" Version="4.11.1" Condition=" '$(TargetFramework)' == 'net46' " />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="CopyOnWrite" />
<PackageReference Include="Microsoft.Build.Framework" />
<PackageReference Include="Microsoft.Build" Condition="'$(TargetFramework)' != 'net6.0' And '$(TargetFramework)' != 'net7.0' " />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Microsoft.Win32.Registry" />
<PackageReference Include="MSBuild.ProjectCreation" />
<PackageReference Include="Newtonsoft.Json" />
<PackageReference Include="Shouldly" />
<PackageReference Include="System.CodeDom" />
<PackageReference Include="System.Collections.Immutable" />
<PackageReference Include="System.Text.Json" Condition="'$(TargetFramework)' != 'net6.0' And '$(TargetFramework)' != 'net7.0' " />
<PackageReference Include="xunit" />
<PackageReference Include="xunit.runner.visualstudio" />
</ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/NoTargets.UnitTests/NoTargetsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,9 @@ public void SimpleBuild(string projectExtension)
}

[Theory]
#if !NETFRAMEWORK
[InlineData(".csproj")]
#endif
[InlineData(".proj", Skip = "Currently broken because of a regression in Static Graph when the extension is .proj")]
public void StaticGraphBuildsSucceed(string projectExtension)
{
Expand Down

0 comments on commit 947e614

Please sign in to comment.