[python] sorting parameters #953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it does not solve the issue, we should check user not set two parameters which are alias to each other in c++. |
|
@wxchan Yeah, I don't say it will solve the issue, it will guarantee the same behavior, independent from the platform, Python version, etc. |
|
@StrikerRUS I am not sure if it works because parameters are also stored in unordered map in c++ too. https://github.com/Microsoft/LightGBM/blob/master/src/io/config.cpp#L16 |
|
@wxchan Oh, didn't notice that. |
|
Close due to #961. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to this and this.
Now there shouldn't occur situations when adding
print()for debugging (for instance) changes behavior.