Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] only warn about early stopping and DART boosting being incompatible if early stopping was requested #6619

Merged
merged 5 commits into from
Aug 21, 2024

Commits on Aug 19, 2024

  1. Update test_parameters.R, lgb.cv.R and lgb.train.R

    * Issue: When using the 'dart'-booster, the lgb.cv()- and lgb.train()-function would trow a warning regardless of the specified model. See issue microsoft#6612
    
    * Fix: The associated functions have been fixed by adding a nested if-statement that only triggers if the dart-booster is specified with early_stopping_rounds != NULL.
    
    * Unittests: The unit-test in test_parameters.R have been rewritten in the following way
    
    	* The lightgbm()-test have had a expect_no_warning()-clause added if the model is correctly specified.
    
    	* A new unittest have been created that checks wether lgb.cv() throws a warning errorneously.
    
    This commit closes microsoft#6612. 🔧
    serkor1 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a2d7928 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: James Lamb <jaylamb20@gmail.com>
    serkor1 and jameslamb committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d38b84c View commit details
    Browse the repository at this point in the history
  3. Replacing expect_no_warning() with expect_silent()

    * expect_no_warning() can't be found on R 3.6.0, so an attempt
    with expect_silent() will be made.
    serkor1 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    257ad6a View commit details
    Browse the repository at this point in the history
  4. lintr-compliance

    * Added spaces after if-statements in lgb.cv() and lgb.train()
    * Reduced the character length of unittests to 120 characters
    serkor1 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2a866e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    fc35b10 View commit details
    Browse the repository at this point in the history