[ci] resolve shellcheck errors in .ci/test_r_packages.sh

[Kunal-Singh-Dadhwal]

Contributes to #6498

So here i rectified the errors in test_r_packages.sh and also checked it with shellcheck

[Kunal-Singh-Dadhwal]

@microsoft-github-policy-service agree

[Kunal-Singh-Dadhwal]

@microsoft-github-policy-service agree

…

On Fri, 21 Jun, 2024, 7:19 pm microsoft-github-policy-service[bot], < ***@***.***> wrote: @Kunal-Singh-Dadhwal <https://github.com/Kunal-Singh-Dadhwal> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. @microsoft-github-policy-service agree [company="{your company}"] Options: - (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @microsoft-github-policy-service agree - (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer. @microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement Contribution License Agreement This Contribution License Agreement (*“Agreement”*) is agreed to by the party signing below (*“You”*), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below. 1. *Definitions*. *“Code”* means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. *“Project”* means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org). *“Submit”* is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” *“Submission”* means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation. 2. *Your Submission*. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project. 3. *Originality of Work*. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions. 4. *Your Employer*. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions. 5. *Licenses*. - *Copyright License*. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties. - *Patent License*. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project. - *Other Rights Reserved*. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise. 6. *Representations and Warranties*. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE. 7. *Notice to Microsoft*. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect. 8. *Information about Submissions*. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission. 9. *Governing Law/Jurisdiction*. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens. 10. *Entire Agreement/Assignment*. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft. — Reply to this email directly, view it on GitHub <#6501 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BE7USZATYVREIAWOPP4E2CDZIQVODAVCNFSM6AAAAABJV7C3DSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSG44TGNBXGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jameslamb]

Thanks for your interest in LightGBM!

I've added a link to the issue I suspect you found this work from (#6498). Please do that in the future, it helps everyone involved to understand why you're proposing these changes.

Please click through the links to CI jobs and fix the failures reported there. You can @ me help if you need it.

Also... in the future, when you contribute to open source projects on GitHub, don't use the master / main branch of your fork. Create a new branch with your changes. Now that there have been some changes merged to master here, when you merge those into your fork's master branch, it'll have a different history than this repo's master branch, which will cause problems if you create another pull request in the future.

[jameslamb]

Please also merge the latest state of master into this branch.

[Kunal-Singh-Dadhwal]

Actually this was my first open source contribution. Thank you for your feedback and guidance! I appreciate your insights and will make sure to follow your suggestions for future contributions.

[Kunal-Singh-Dadhwal]

Please also merge the latest state of master into this branch

Should i make my own branch and push these changes

[jameslamb]

this was my first open source contribution.

Oh great, thanks for choosing LightGBM for that! We're happy to have you.

In the future, when you make a contribution (especially to a project you've never worked on before), please provide more information in the pull request title / description than "resolve errors". For example, can you please update the description here with the full text of all the errors you're trying to address?

That'd help reviewers to understand specifically what you are attempting to fix, and would help answer the important question "why should we merge this? how does this improve the project?".

[jameslamb]

Should i make my own branch and push these changes

Not for this PR. After this PR is merged, you should do the following if you intend to contribute here again:

• delete your LigthGBM fork here on GitHub
• recreate it

And then in the future if you contribute here, you should work from a new branch on your fork for every pull request, like this:

git checkout -b ci/shellcheck

[jameslamb]

Can you please merge in master again and resolve conflicts?

We had an in-progress pull request (#6497) that touched some of the same lines in in .ci/test_r_package.sh as this one does, and I've just merged that.

[jameslamb]

This is getting closer!

Please look through the diff at https://github.com/microsoft/LightGBM/pull/6501/files to identify whitespace-only changes, and please revert those.

I see two. This one on line 151 where you've added back these spaces I asked you to remove:

And this one, where you've removed an entire line:

If you're unsure how to find those extra space characters, consider changing the settings in your editor to display whitespace characters.

[Kunal-Singh-Dadhwal]

@jameslamb removed whitespaces

[jameslamb]

Please put this line back:

[jameslamb]

Thanks, but it seems that the most recent commit you pushed re-introduced those extra space characters. I think maybe you aren't aware of how to identify space-only characters when adding text files.

No problem, in some editors they're hidden! To get this PR merged, I just pushed a commit removing those. You can view it here: e1c71cc

You may want to turn on display of whitespace characters in your editor. Here's what this file looks like to me in VS Code (note that dots for spaces):

[Kunal-Singh-Dadhwal]

Will check thoroughly the next time I make any contribution. Thanks for your patience and guidance

[jameslamb]

Thanks very much for this!

I've pushed a few commits here to finish this.

We'd love your help with more shellcheck things to make progress on #6498 if it interests you. If you do submit future pull requests ("PR"), please consider the suggestions I've given in this review:

• do not use the master branch... create a new branch on your fork, from master
• link to [ci] enforce 'shellcheck' checks #6498 in the description of the PR
• add the exact text of the errors that your PR seeks to fix, in the description of the PR, formatted as a code block following https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#quoting-code

[jameslamb]

@Kunal-Singh-Dadhwal it looks like you deleted your fork before this was merged, so now your work won't actually be added to LightGBM. I strongly suspect that was a mistake.

If it was and you are still interested in contributing these changes, please open a new pull request.

[Kunal-Singh-Dadhwal]

@jameslamb Yes it was a mistake Sorry ,I would make another PR by today