Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] update issue-locking workflow #6256

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[ci] update issue-locking workflow #6256

merged 1 commit into from
Jan 3, 2024

Conversation

jameslamb
Copy link
Collaborator

Proposes a few changes to the GitHub Actions workflow we use to close issues and labels:

Why now?

@dessant, the author of lock-threads, tagged me to tell me that extra double quotes are no longer necessary: dessant/lock-threads#40 (comment).

Why increase the time-til-locking?

I've found that locking a PR / issue prevents GitHub from generating these annotations showing that the PR / issue was mentioned somewhere else.

image

I've found those annotations really useful, for example to discover problems in other projects that were caused by changes here.

I'd like to extend the time-til-locking so that we can see more of those annotations in the time after a release.

@jameslamb jameslamb merged commit 2bd60c8 into master Jan 3, 2024
41 checks passed
@jameslamb jameslamb deleted the ci/no-quotes branch January 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants