-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] fix broken links #6161
[docs] fix broken links #6161
Conversation
@@ -11,7 +11,7 @@ ignore= | |||
http.*amd.com/.* | |||
https.*dl.acm.org/doi/.* | |||
https.*tandfonline.com/.* | |||
ignorewarnings=http-robots-denied,https-certificate-error | |||
ignorewarnings=http-redirected,http-robots-denied,https-certificate-error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like as of the most recent release of linkchecker
(v10.3.0), HTTP redirects now throw a warning.
From this PR: linkchecker/linkchecker#750
That's leading to this job failing even with 0 errors. (example build)
That's it. 1087 links in 1115 URLs checked. 28 warnings found. 0 errors found.
Error: Process completed with exit code 255.
In this PR, I'm proposing not considering the presence of such warnings to cause the job to fail. It'll take some time to go through the 28 warnings and fix them, and I'd prefer to get this job working again as soon as possible to catch truly broken links.
If reviewers agree, I'll put up a new issue documenting the desire to remove this filter and enforce no-redirects in this job again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I triggered check-links
on this branch before adding this change to the config: https://github.com/microsoft/LightGBM/actions/runs/6766475624/job/18387635055
And despite there being 0 errors in the result ...
That's it. 1088 links in 1116 URLs checked. 28 warnings found. 0 errors found.
Stopped checking at 2023-11-06 05:04:50+000 (6 minutes, 20 seconds)
... it's still failing
Error: Process completed with exit code 255.
I suspect that maybe linkchecker
returns a non-0 exit code if any warnings are found. The last successful run in this project was https://github.com/microsoft/LightGBM/actions/runs/6219774651/job/16878494852, and that ended with:
That's it. 1089 links in 1125 URLs checked. 0 warnings found. 0 errors found.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
The
check-links
CI job is failing as a result of broken links (recent build).This PR fixes those errors:
Kubeflow Fairing is no longer supported (click me)
See kubeflow/fairing#573.
And at https://github.com/kubeflow/fairing/tree/master
And https://www.kubeflow.org/docs/external-add-ons/fairing/fairing-overview
Paris Kaggle Meetup slides have been removed or made private (click me)
https://drive.google.com/file/d/0B6qJBmoIxFe0ZHNCOXdoRWMxUm8/view
MSLR dataset moved (click me)
SWIG docs site requests sometimes fail (click me)
I suspect that that might be a result of the use of
http://
instead ofhttps://
... maybe that site is doing a redirection ofhttp://
traffic that results in failures.While looking through this, I also saw 2 warnings about redirects from
http://
tohttps://
pages.. this PR fixes those as well.redirects (click me)
Notes for Reviewers
✅ triggered the job on this branch and saw it succeed: https://github.com/microsoft/LightGBM/actions/runs/6766631790