[python-package] fix _LGBM_CustomMetricFunction typing #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deimos357
requested review from
StrikerRUS,
shiyu1994,
jameslamb and
jmoralez
as code owners
Deimos357
changed the title
jameslamb
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Thanks for the help! I agree with these changes.
Some tips to help you in future open source contributions:
- Link to the documentation you're referring to instead of just typing it out.
- Make pull requests from a branch other than the target branch (see [python-package] prefix is_numpy_1d_array with _ #5520 (comment) for an explanation)
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3756.
Fixed custom evaluation function typing according to train documentation: "Each evaluation function should accept two parameters: preds, eval_data, and return (eval_name, eval_result, is_higher_better) or list of such tuples."